Coordinator stopped on bad control command #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hennzau
force-pushed
the
648-coordinator-crashes-on-bad-logs-access
branch
from
9f12f03
to
ed35332
Compare
Hennzau
force-pushed
the
648-coordinator-crashes-on-bad-logs-access
branch
from
343f7d7
to
01fa7b8
Compare
haixuanTao
approved these changes
Sep 11, 2024
| dataflow, | ||
| uuid, | ||
| for dataflow_uuid in running_dataflows.keys().cloned().collect::<Vec<_>>() { | ||
| let _ = stop_dataflow( |
There was a problem hiding this comment.
Do we really need to change the stop_dataflow return type if we are not using it?
There was a problem hiding this comment.
We are using it in the control loop for dora stop but not for the dora destroy command. But its more readable if we don't have 2 different functions to do that.
let dataflow = stop_dataflow(
&mut running_dataflows,
dataflow_uuid,
&mut daemon_connections,
clock.new_timestamp(),
grace_duration,
)
.await;
match dataflow {
Ok(dataflow) => {
dataflow.reply_senders.push(reply_sender);
}
Err(err) => {
let _ = reply_sender.send(Err(err));
}
}There was a problem hiding this comment.
Ah ok make sense! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #648 and more